Fix Judge Selector not Loading in PROD#455
Merged
ronaldo-macapobre merged 1 commit intomasterfrom Aug 27, 2025
Merged
Conversation
…which causes duplicate API calls.
ronaldo-macapobre
requested review from
JTraill,
WadeBarnes and
devinleighsmith
|
devinleighsmith
approved these changes
Aug 27, 2025
WadeBarnes
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
JudgeSelectoris mounted, an API called is triggered to get the list of judges. Upon investigation, theJudgeSelectorcomponent is mounting twice due to its placement insidev-tabs. Sincev-tabswraps its slot content in av-slide-group, non v-tab children gets duplicated. Thus, duplicate API calls.The fix is to move the loading of judges on the parent component (
App.vue) to ensure data is only retrieved once.Screen Grab
Judge-Selector.mp4