-
Notifications
You must be signed in to change notification settings - Fork 22
Feat/generate opportunity report #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: in-app-evaluation
Are you sure you want to change the base?
Conversation
…d team scenario tab contents
…/bcgov/digital_marketplace into feat/generate-opportunity-report merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After further consideration, I don't think reusing the existing components are the best use case for this because:
- The report is meant to be read-only
- Components in Marketplace are used for state management
- We shouldn't be modifying the interface of existing components to pacify the requirements of the new report
Instead the src/front-end/typescript/lib/pages/opportunity/:program/complete/index.tsx pages should should execute the necessary Cmds to load all of the data it needs from the back-end and populate some sort of read-only view; you have a few options for this from least to most preferred:
- Use the existing component's views and finesse the data into a shape that conforms to the state it accepts (i.e. component_.page.View<State, InnerMsg, Route>)
- Create new read-only views (i.e. component.base.View<SomeProps>)
- Implement a new view for the components used in the report that accepts certain props (not state from the component). Then, refactor the component to "pass through" the relevant props from component state to the view
|
This PR closes issue: [issue #DMM-457]
Includes tests? N
Updated docs? N
Proposed changes: