Sc3690 - update packages and docker node version #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
jatindersingh93
changed the title
norrisng-bc
reviewed
Jul 15, 2024
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM docker.io/node:20.11.1-alpine | |||
| FROM docker.io/node:lts-alpine3.20 | |||
There was a problem hiding this comment.
Isn't it generally a better idea to use a specific version number instead of just the lts tag? Things could break in a future LTS version.
There was a problem hiding this comment.
Oh i think youre right.
we could use 20.15.1-alpine3.20 instead
TimCsaky
reviewed
Jul 15, 2024
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM docker.io/node:20.11.1-alpine | |||
| FROM docker.io/node:lts-alpine3.20 | |||
There was a problem hiding this comment.
Oh i think youre right.
we could use 20.15.1-alpine3.20 instead
TimCsaky
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments