-
Notifications
You must be signed in to change notification settings - Fork 9
Adding inactive or active tabs to devices container #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: collections
Are you sure you want to change the base?
Conversation
|
Openshift URLs for the PR Deployment: |
…ue going onto new line
LouisThedroux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have gone over this and made a bunch of changes. It is working as it should now with some tweaks to styling etc.
|
Code duplication failed. Will go over it again and try to refine where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the telemetry devices management interface to distinguish between active and inactive devices based on their deployment status. It replaces bulk actions and device deletion functionality with a toggle system that filters devices by their deployment state.
- Removes bulk selection, deletion, and import functionality from devices management
- Adds active/inactive device filtering with toggle buttons based on deployment status
- Removes the "Deployed On" animal column from the devices table and replaces action menu options
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
DevicesTable.tsx |
Removes device deletion, bulk selection, and "Deployed On" column; simplifies menu actions |
DevicesContainer.tsx |
Adds active/inactive device filtering with toggle buttons and helper functions for deployment status |
SurveyDeploymentListItem.tsx |
Removes checkbox selection functionality from deployment list items |
SurveyDeploymentList.tsx |
Removes bulk actions and deletion functionality from deployment list |
SurveySpatialTelemetry.tsx |
Updates import statement and navigation routing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
app/src/features/surveys/telemetry/manage/devices/table/DevicesContainer.tsx
Outdated
Show resolved
Hide resolved
app/src/features/surveys/telemetry/manage/devices/table/DevicesContainer.tsx
Show resolved
Hide resolved
app/src/features/surveys/telemetry/list/SurveyDeploymentList.tsx
Outdated
Show resolved
Hide resolved
|
LouisThedroux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gone over and changed a few things but is working and looks better now.



Description of Changes
Testing Notes