Skip to content

Conversation

@mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Dec 6, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • Adds pages for creating and editing survey blocks
  • Paginated the survey blocks /get endpoint (blocks contain potentially complex geometry like sites)
  • Renames "Blocks" to "Clusters" (frontend labels only) because blocks is frequently conflated with sampling sites by users
  • Moves survey blocks from the survey form to its own concept on the manage sampling page
  • TODO: Improve performance when importing big spatial files

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

@mauberti-bc mauberti-bc changed the title SIMSBIOHUB-649: Add Survey Blocks Page SIMSBIOHUB-649: Create Survey Blocks Page Dec 6, 2024
@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Dec 6, 2024
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 18.88112% with 464 lines in your changes missing coverage. Please review.

Project coverage is 45.06%. Comparing base (a7bcd49) to head (72ca264).

Files with missing lines Patch % Lines
...rmation/blocks/form/create/CreateBlocksMapForm.tsx 2.53% 77 Missing ⚠️
...ormation/sites/table/SamplingSiteTabsContainer.tsx 0.00% 54 Missing ⚠️
...information/blocks/form/edit/EditBlocksMapForm.tsx 0.00% 40 Missing ⚠️
app/src/components/map/ImportDrawMapControl.tsx 3.03% 32 Missing ⚠️
...ling-information/blocks/create/CreateBlockPage.tsx 0.00% 31 Missing ⚠️
...sampling-information/blocks/edit/EditBlockPage.tsx 0.00% 30 Missing ⚠️
...tion/sites/table/tabs/blocks/SurveyBlocksTable.tsx 0.00% 30 Missing ⚠️
...s/table/tabs/blocks/SurveyBlocksTableContainer.tsx 0.00% 23 Missing ⚠️
...es/table/tabs/sites/SamplingSiteTableContainer.tsx 0.00% 23 Missing ⚠️
app/src/components/card/CollapsibleCardList.tsx 4.34% 22 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1447      +/-   ##
==========================================
- Coverage   45.60%   45.06%   -0.54%     
==========================================
  Files         845      856      +11     
  Lines       22296    22728     +432     
  Branches     3301     3345      +44     
==========================================
+ Hits        10167    10243      +76     
- Misses      11532    11887     +355     
- Partials      597      598       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mauberti-bc mauberti-bc marked this pull request as ready for review December 19, 2024 20:56
@github-actions
Copy link

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mauberti-bc mauberti-bc added the Do Not Merge PR should not be merged label Mar 25, 2025
@dylanrogowsky-oxd dylanrogowsky-oxd force-pushed the dev branch 4 times, most recently from 9d98b27 to ca95d07 Compare September 18, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge PR should not be merged Early Feedback Welcome PR is not finished, but early review feedback is welcomed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants