Repository navigation
Conversation
…ld carry its own key type to prevent using keys across algorithms. This ended up being harder than it looked and ended up adding a new public trait SymmetricCipherKey\<KEY_LEN\> which is a shallow wrapper for a KeyMaterial\<KEY_LEN\>, and then carrying a generic param 'K: SymmetricCipherKey\<KEY_LEN\>' all the way down the stack of stuff in the bouncycastle-cipher crate. Touched a ton of files, but everything works now, and I think it's prettier than the old system with bare KeyMaterials. Heavily assisted-by: Claude Fable 5.1
Contributor
Author
|
Marking as Draft because I want to review it carefully myself first. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each symmetric cipher instantiation (AES_GCM_128, Ascon_AEAD128) should carry its own key type to prevent using keys across algorithms. This ended up being harder than it looked and ended up adding a new public trait SymmetricCipherKey<KEY_LEN> which is a shallow wrapper for a KeyMaterial<KEY_LEN>, and then carrying a generic param 'K: SymmetricCipherKey<KEY_LEN>' all the way down the stack of stuff in the bouncycastle-cipher crate. Touched a ton of files, but everything works now, and I think it's prettier than the old system with bare KeyMaterials. Heavily assisted-by: Claude Fable 5.1