Repository navigation
Feat: Add ChaCha20, Poly1305, and Chacha20-Poly1305-AEAD - #157
Draft
officialfrancismendoza wants to merge 8 commits into
Conversation
…eature/officialfrancismendoza/145-chacha20-poly1305-AEAD-updated
…eature/officialfrancismendoza/145-chacha20-poly1305-AEAD-updated
…eature/officialfrancismendoza/145-chacha20-poly1305-AEAD-updated # Conflicts: # Cargo.toml # src/lib.rs
Contributor
Author
|
@dghgit resolved the merge conflicts upstream, so ready for review :) |
dghgit
requested changes
Oct 4, 2026
dghgit
left a comment
dghgit
left a comment
Contributor
There was a problem hiding this comment.
It's getting their, algorithmic fine, more a few integration and consistency issues. Have sent a report.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on RFC 8439, implement three separate chacha20, poly1305, and chacha20-poly1305-AEAD crates compatible with the new API shape (implements #145).