Skip to content

Exception testing for CTS mode #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

timw
Copy link
Contributor

@timw timw commented Jul 17, 2013

Add exception testing (as already exist for other modes) for CTS mode.
Fix a couple of minor issues arising from those tests.

Added TODO to fix hacky checking of cipher compatibility when there is a stable mechanism to differentiate primitive block ciphers from block cipher modes - BC isn't very clean about the block cipher/block cipher mode separation.

…hose tests.

Added TODO about stable mechanism to differentiate primitive block ciphers from block cipher modes.
@ghost ghost assigned bcgit Sep 7, 2013
@bcgit
Copy link
Collaborator

bcgit commented Sep 7, 2013

It's about as clean as the way we produce the modes... I agree about the TODO though, the conditional will continue to telescope if a marker interface isn't used. Going to ponder it, my feeling at the moment is introducing a BlockCipherEngine interface which extends BlockCipher may be the answer - then the if would be against BlockCipherEngine and CBCBlockCipher. I have left the TODO in place.

@bcgit bcgit closed this Sep 7, 2013
@bcgit bcgit removed their assignment May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants