OpenPGPKey.join() - #2170
Draft
vanitasvitae wants to merge 2622 commits into
Draft
Conversation
Update KeyIdentifier and related classes, update FingerprintUtil, remove OpenPGPV6KeyGenerator See merge request root/bc-java!106
Add kem hqc jdk21 See merge request root/bc-java!102
Set message and content as protected in SMIMESignedParser See merge request root/bc-java!107
… runeflobakk-add-bom
cleaned up algorithm list for composites.
Pqc hqc update v5 See merge request root/bc-java!117
updated to 1.82.
vanitasvitae
marked this pull request as draft
September 27, 2025 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
OpenPGPCertificate.join()methods with non-static members and implements join logic for the OpenPGPKey class.TODO: Write tests ensuring proper behaviour.