Skip to content

Comments

Trap errors in callbacks#4

Open
rzr wants to merge 2 commits intobbx10:masterfrom
CrossStream:sandbox/rzr/node/review/master
Open

Trap errors in callbacks#4
rzr wants to merge 2 commits intobbx10:masterfrom
CrossStream:sandbox/rzr/node/review/master

Conversation

@rzr
Copy link

@rzr rzr commented Jan 17, 2020

Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: https://github.com/bbx10/node-htu21d/pulls
Signed-off-by: Philippe Coval rzr@users.sf.net

rzr added a commit to CrossStream/node-htu21d that referenced this pull request Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: bbx10#4
Signed-off-by: Philippe Coval <rzr@users.sf.net>
@rzr rzr force-pushed the sandbox/rzr/node/review/master branch from d640c3f to d6a6149 Compare January 17, 2020 13:30
rzr added a commit to CrossStream/node-htu21d that referenced this pull request Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: bbx10#4
Signed-off-by: Philippe Coval <rzr@users.sf.net>
@rzr rzr force-pushed the sandbox/rzr/node/review/master branch from d6a6149 to 2a911ba Compare January 17, 2020 13:37
rzr added a commit to CrossStream/node-htu21d that referenced this pull request Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: bbx10#4
Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr added a commit to CrossStream/node-htu21d that referenced this pull request Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: bbx10#4
Signed-off-by: Philippe Coval <rzr@users.sf.net>
@rzr rzr force-pushed the sandbox/rzr/node/review/master branch from 2a911ba to af2f6e4 Compare January 17, 2020 14:03
rzr added a commit to CrossStream/node-htu21d that referenced this pull request Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: bbx10#4
Signed-off-by: Philippe Coval <rzr@users.sf.net>
@rzr rzr force-pushed the sandbox/rzr/node/review/master branch from af2f6e4 to 1a2d54d Compare January 17, 2020 17:14
Copy link
Author

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider merging this change it was tested by @dror3go

I plan to pull it in next version of:

https://github.com/rzr/generic-sensors-lite

@dror3go
Copy link

dror3go commented Jan 21, 2020

Looks good, and I can confirm that this is working. cc @bbx10

rzr added 2 commits February 7, 2020 08:22
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: bbx10#4
Signed-off-by: Philippe Coval <rzr@users.sf.net>
Change-Id: I6457129c7fbd1504d1c476f9079f64115b7c917b
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: bbx10#4
Signed-off-by: Philippe Coval <rzr@users.sf.net>
@rzr rzr force-pushed the sandbox/rzr/node/review/master branch from 1a2d54d to 38ea93c Compare February 7, 2020 07:23
@rzr
Copy link
Author

rzr commented Feb 7, 2020

This change has been released in:
https://www.npmjs.com/package/@abandonware/htu21d-i2c/v/0.1.1-0

@rzr
Copy link
Author

rzr commented May 25, 2020

Please feedback welcome on this PR

If this package is no more maintained may you consider to transfer it to:

https://abandonware.github.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants