Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code owners to teams #87

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

marco-bertschi
Copy link
Contributor

@marco-bertschi marco-bertschi commented Jun 11, 2020

Update code owners to teams for easier maintenance

@marco-bertschi marco-bertschi changed the title update code owners Update code owners to teams Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #87 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          127       127           
  Branches        16        16           
=========================================
  Hits           127       127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38aaf00...24e80f8. Read the comment docs.

Copy link
Collaborator

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work like this (see bbtsoftware/BBT.StrategyPattern#36)

@marco-bertschi
Copy link
Contributor Author

Doesn't seem to work like this (see bbtsoftware/BBT.StrategyPattern#36)

I don't get it, bbtsoftware/BBT.StrategyPattern#36 is about using inheritdoc whereas this PR is about updating the code owners?

@pascalberger
Copy link
Collaborator

Doesn't seem to work like this (see [bbtsoftware/BBT.StrategyPattern#36](https://github.com>
I don't get it, bbtsoftware/BBT.StrategyPattern#36 is about using inheritdoc whereas this PR is about updating the code owners?

bbtsoftware/BBT.StrategyPattern#36 was mainly my test if automatic review request are working, which failed. But in the meantime I set teams to public, which might have been the issue

@marco-bertschi
Copy link
Contributor Author

Doesn't seem to work like this (see [bbtsoftware/BBT.StrategyPattern#36](https://github.com>
I don't get it, bbtsoftware/BBT.StrategyPattern#36 is about using inheritdoc whereas this PR is about updating the code owners?

bbtsoftware/BBT.StrategyPattern#36 was mainly my test if automatic review request are working, which failed. But in the meantime I set teams to public, which might have been the issue

Ah I see.

@pascalberger
Copy link
Collaborator

Doesn't seem to work like this (see [bbtsoftware/BBT.StrategyPattern#36](https://github.com>
I don't get it, bbtsoftware/BBT.StrategyPattern#36 is about using inheritdoc whereas this PR is about updating the code owners?

bbtsoftware/BBT.StrategyPattern#36 was mainly my test if automatic review request are working, which failed. But in the meantime I set teams to public, which might have been the issue

Nope, still not working (bbtsoftware/BBT.StrategyPattern#38)

@marco-bertschi
Copy link
Contributor Author

Alright, abandoning this in favour of a working solution then?

Copy link
Collaborator

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the required changes to the team settings so that this should work now

@marco-bertschi marco-bertschi merged commit 3119266 into develop Jun 11, 2020
@marco-bertschi marco-bertschi deleted the feature/update-codeowners branch June 11, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants