Make Emscripten SDK (emsdk) version a workflow input

Closes #143
bblanchon · Nov 14, 2023 · 60429bf · 60429bf
1 parent e2cb2b3
commit 60429bf
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.github/workflows/build-one.yml b/.github/workflows/build-one.yml
@@ -41,6 +41,11 @@ on:
         type: boolean
         required: false
         default: false
+      emsdk_version:
+        description: Emscripten SDK
+        type: string
+        required: false
+        default: 3.1.34
       is_debug:
         description: Is debug
         type: boolean
@@ -59,3 +64,4 @@ jobs:
       target_cpu: ${{ github.event.inputs.target_cpu }}
       target_libc: ${{ github.event.inputs.target_libc }}
       enable_v8: ${{ github.event.inputs.enable_v8 == 'true' }}
+      emsdk_version: ${{ github.event.inputs.emsdk_version }}
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -36,6 +36,11 @@ on:
         type: string
         required: false
         default: ''
+      emsdk_version:
+        description: Emscripten SDK
+        type: string
+        required: false
+        default: 3.1.34
     outputs:
       artifact:
         description: "The name of the artifact"
@@ -76,6 +81,7 @@ jobs:
           PDFium_TARGET_LIBC=${{ inputs.target_libc }}
           PDFium_ENABLE_V8=${{ inputs.enable_v8 }}
           PDFium_VERSION=${{ inputs.version }}
+          EMSDK_VERSION=${{ inputs.emsdk_version }}
           MUSL_URL=${{ secrets.MUSL_URL }}
           END
           steps/00-environment.sh

diff --git a/steps/01-install.sh b/steps/01-install.sh
@@ -98,8 +98,8 @@ case "$TARGET_OS" in
       git clone https://github.com/emscripten-core/emsdk.git
     fi
     pushd emsdk
-    ./emsdk install 3.1.34
-    ./emsdk activate 3.1.34
+    ./emsdk install ${EMSDK_VERSION:-3.1.34}
+    ./emsdk activate ${EMSDK_VERSION:-3.1.34}
     echo "$PWD/upstream/emscripten" >> "$PATH_FILE"
     echo "$PWD/upstream/bin" >> "$PATH_FILE"
     popd