fix: minor race condition bugs (wix#2335)

bbigard · Sep 17, 2020 · d6ba881 · d6ba881
1 parent 61f2d6a
commit d6ba881
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/detox/runners/jest/DetoxAdapterImpl.js b/detox/runners/jest/DetoxAdapterImpl.js
@@ -22,8 +22,10 @@ class DetoxAdapterImpl {
       throw new DetoxRuntimeError(this._describeInitError());
     }
 
+    const currentTest = this._currentTest;
+
     await this._flush();
-    await this.detox.beforeEach(this._currentTest);
+    await this.detox.beforeEach(currentTest);
   }
 
   async afterAll() {

diff --git a/detox/src/artifacts/templates/plugin/WholeTestRecorderPlugin.js b/detox/src/artifacts/templates/plugin/WholeTestRecorderPlugin.js
@@ -23,12 +23,13 @@ class WholeTestRecorderPlugin extends ArtifactPlugin {
     await super.onTestDone(testSummary);
 
     if (this.testRecording) {
-      await this.testRecording.stop();
+      const testRecording = this.testRecording;
+      await testRecording.stop();
 
       if (this.shouldKeepArtifactOfTest(testSummary)) {
-        this._startSavingTestRecording(this.testRecording, testSummary)
+        this._startSavingTestRecording(testRecording, testSummary)
       } else {
-        this._startDiscardingTestRecording(this.testRecording);
+        this._startDiscardingTestRecording(testRecording);
       }
 
       this.testRecording = null;