For reverse proxies, add SWAGGER_HOST environment variable support #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `SWAGGER_HOST` environment variable to `README.md` for Swagger UI configuration. - Update `main.go` to use `SWAGGER_HOST` environment variable for Swagger UI host configuration.
|
Many thanks! |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issue that I could not easily test this service behind a reverse proxy, because of the hard-coded
IP:PORTset up. This should fix that. Please let me know if you need any other related changes before this can be accepted.Changes:
SWAGGER_HOSTenvironment variable toREADME.mdfor Swagger UI configuration.main.goto useSWAGGER_HOSTenvironment variable for Swagger UI host configuration.