Skip to content

Add sentry lib #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

KyryloKrasiuk
Copy link

Proposal to add Sentry to the project.

Sometimes there are errors in the logs and it is necessary to somehow monitor them.

@bbernhard
Copy link
Owner

Is there a specific reason why you prefer Sentry over other log monitoring solutions that don't require code changes? I've used Sentry in the past and I also quite liked it, but I am not sure if it is a good idea to add that kind of monitoring to a software that is particular privacy focused.

I know, that one must configure a SENTRY_DSN before the application sends data to the Sentry Server, but I imagine that this will result in some questions from users that do not know Sentry well enough and are afraid about their privacy (which I can totally understand).

@KyryloKrasiuk
Copy link
Author

This is the first option I thought of.
In those cases where I don't have access to the container (SSH) and can't install additional services to monitor logs, this seemed like a good option.

Maybe you have recommendations on how to better collect logs and errors? Because the other option is to make my own Dockerfile based on yours.

@poggenpower
Copy link

I agree with @bbernhard , this kind of proprietary 3rd party dependencies should not be hard coded into the signal-cli-rest-api.
@KyryloKrasiuk if you really need sentry integration, patch sentry into signal-cli-rest-api and build it on your own. From the changes required this should work pretty reliable and this should be easy to automate that you get your preferred logging solution in.
There are tons of solutions to monitor containers. At the end you can use the signal-cli-rest-api image as base image and add all software you need to do your favorite logging. For containers is it very common to log to stdout, which is collected by the container runtime. It seems https://sematext.com/guides/docker-logs/ is a good starting point if you use docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants