Skip to content

Pass JAVA_OPTS through to signal-cli in json-rpc mode #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

kleptog
Copy link

@kleptog kleptog commented Feb 5, 2024

Fixes #473

@bbernhard
Copy link
Owner

Thanks for the PR - very much appreciated!

Just a small thing: Would it be possible to use >> instead of >, so that the changes are appended to the file instead of the whole file getting replaced? Right now, it doesn't matter much, as we do not have anything in there, except your JAVA_OPTS. But maybe at a later point someone writes something to the file as well. And then your > would overwrite those changes again.

What do you think? :)

@kleptog kleptog force-pushed the java-opts-in-json-rpc branch from e59a86c to c2d9703 Compare February 14, 2024 13:28
@kleptog kleptog force-pushed the java-opts-in-json-rpc branch from c2d9703 to b00be63 Compare February 14, 2024 13:31
@kleptog
Copy link
Author

kleptog commented Feb 14, 2024

Fair enough. When writing it I was going either way, but I don't mind.

Update pushed

@bbernhard
Copy link
Owner

Many thanks for the contribution!

@bbernhard bbernhard merged commit 7be6169 into bbernhard:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JAVA_OPTS are ignored when using json-rpc mode
2 participants