Added Expiration for Contact #143
Conversation
| log.Debug("*) su signal-api") | ||
| log.Debug("*) ", fullCmd) | ||
| log.Debug("*) ", signalCliBinary, " ", strings.Join(args, " ")) | ||
|
|
There was a problem hiding this comment.
I think you accidentally removed some code here (probably due to a merging conflict), see: https://github.com/bbernhard/signal-cli-rest-api/blob/master/src/api/api.go#L345
| } | ||
|
|
||
| if len(req.Name) == 0 { | ||
| c.JSON(400, gin.H{"error": "Couldn't process request - please provide the recipients name number"}) |
| } | ||
|
|
||
| if len(req.Expiration) == 0 { | ||
| c.JSON(400, gin.H{"error": "Couldn't process request - please provide an expirty time in seconds"}) |
| type UpdateContactRequest struct { | ||
| Name string `json:"name"` | ||
| Number string `json:"number"` | ||
| Expiration string `json:"expiration"` |
There was a problem hiding this comment.
I think it makes sense to change the type to int here. Maybe also make it more clear that it's a time?
so e.g something like: ExpirationTime int json:"expiration_time"``?
| @@ -139,6 +139,11 @@ func main() { | |||
| identities.GET(":number", api.ListIdentities) | |||
| identities.PUT(":number/trust/:numbertotrust", api.TrustIdentity) | |||
| } | |||
|
|
|||
| contacts := v1.Group("updatecontact") | |||
There was a problem hiding this comment.
Personally I would prefer if we could change the endpoint to contacts, as the POST method already implies that it will be a update/change request. I think what we probably also should do here is to restrict the request to a certain signal instance number. i.e: contacts/:number. And pass that number then also with -u to the runSignalCli function.
Added Expiration for Contact to Signal CLI. I haven't much of a clue of how .go works so you might need to re-run the swagger to pull the doc interface. its listed under v1 update contact and the API appears to work. User must set the expiration prior to sending a message as previous messages aren't linked to the new timeout.