Minor refactor to decouple hex generation from button actions. #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way features that need to hook to this functionality only need to fo a function call with less chance for merge conflicts. .
microbit-carlos
force-pushed
the
simplify_integration
branch
from
e06bc18 to
3392989
Compare
microbit-sam
approved these changes
Feb 26, 2019
microbit-mark
pushed a commit
to microbit-mark/PythonEditor
that referenced
this pull request
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way new features that need to hook to this functionality only need to fo a function call with less chance for integration conflicts.
The overlap area turned out to be smaller than I expected, so the main change is the creation of
generateFullHexStr().Also added
'use strict';to the two objects and edited minor things jslint complained about.