Skip to content

add new langauges to en.js #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

microbit-mark
Copy link
Contributor

Missed this in the last language update, we list all languages here for translation in crowdin.

lang/en.js Outdated
'title': 'Norwegian Nynorsk'
},
'pt': {
'title': 'Portugese'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right, is this a misspelling of the English word? Or is it meant to be the Portuguese translation (in that case I don't think it's right, but I'm not 100% sure).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carlos. It was a spelling mistake. Fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark. Look like the typo is also in the editor.html file, could you fix that one as well?

<li><span title="Portugese"><a lang="pt" href="#" class="action lang-choice" id="pt" tabindex="132">Português</a></span></li>

Copy link
Collaborator

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Mark!

@microbit-carlos microbit-carlos merged commit 869f65e into bbcmicrobit:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants