Skip to content

Delete titles on error modal links #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Delete titles on error modal links #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,10 +1418,10 @@ function web_editor(config) {
// If err is not device disconnected or if there is previous errors, append the download/troubleshoot buttons
var showOverlayButtons = "";
if(err.name !== 'device-disconnected' || $("#flashing-overlay-error").html() !== "") {
showOverlayButtons = '<a href="#" id="flashing-overlay-download" class="action" onclick="actionClickListener(event)">' +
showOverlayButtons = '<a title="" href="#" id="flashing-overlay-download" class="action" onclick="actionClickListener(event)">' +
config["translate"]["webusb"]["download"] +
'</a> | ' +
'<a target="_blank" href="https://support.microbit.org/solution/articles/19000105428-webusb-troubleshooting/en" id="flashing-overlay-troubleshoot" class="action" onclick="actionClickListener(event)">' +
'<a title="" target="_blank" href="https://support.microbit.org/solution/articles/19000105428-webusb-troubleshooting/en" id="flashing-overlay-troubleshoot" class="action" onclick="actionClickListener(event)">' +
config["translate"]["webusb"]["troubleshoot"] +
'</a> | ';
}
Expand All @@ -1436,7 +1436,7 @@ function web_editor(config) {
'<div class="flashing-overlay-buttons">' +
'<hr />' +
showOverlayButtons +
'<a href="#" onclick="flashErrorClose()">' + config["translate"]["webusb"]["close"] + '</a>' +
'<a title="" href="#" onclick="flashErrorClose()">' + config["translate"]["webusb"]["close"] + '</a>' +
'</div>';

// Show error message, or append to existing errors
Expand Down