Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape pathnames for shell in compare_images.rb [Fixes #527] #603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamsinclair
Copy link

@jamsinclair jamsinclair commented Nov 29, 2018

Bug

Having namespaced paths with spaces causes the compare_images.rb script to hang or fail. This was reported in #527.

Example Bad Path in Wraith Config File

paths:
  Site Home: /home.html

This bug is happening because the constructed shell command in compare_images.rb does not escape the supplied pathnames resulting in a faulty compare CLI command.

What this PR does

The included changes make the pathname strings escaped for the shell.

This will allow people to use spaces for their named paths and the compare_images.rb script can correctly compare the files and generate the diff image.

- Allows spaces and special chars to be used with site path namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant