Windows : disk letter in lower case and before_capture option #575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
On Windows, the disk letter is not always uppercase. It could cause a bug with
before_capture
option.Example:
My option :
before_capture: 'javascript/wait--casper.js'
I start cmd, the default path is
C:\Users\my-user
.So i can enter this commands to go to the good path :
This causes an error :
Can't find module f:/project/f:/project/javascript/wait--casper.js
It is because of the regex in
convert_to_absolute
function which wants an uppercase letter for the disk.This PR modify the regex to accept a lowercase letter too.