Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows : disk letter in lower case and before_capture option #575

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

ajoah
Copy link
Contributor

@ajoah ajoah commented Jul 6, 2018

Hi,

On Windows, the disk letter is not always uppercase. It could cause a bug with before_capture option.

Example:

My option :
before_capture: 'javascript/wait--casper.js'

I start cmd, the default path is C:\Users\my-user.
So i can enter this commands to go to the good path :

C:\Users\my-user> cd f:\project
C:\Users\my-user> f:
f:\project>wraith capture configs/spider.yaml`

This causes an error :
Can't find module f:/project/f:/project/javascript/wait--casper.js

It is because of the regex in convert_to_absolute function which wants an uppercase letter for the disk.

This PR modify the regex to accept a lowercase letter too.

@ChrisBAshton ChrisBAshton merged commit 36c1fe7 into bbc:master Jul 31, 2018
@ChrisBAshton
Copy link
Contributor

Thanks for the PR. This has now been released in v4.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants