Ws-3034 High contrast mode - in windows - loader bug fix#14235
Open
jinidev wants to merge 1 commit into
Open
Conversation
Isabella-Mitchell
approved these changes
Jul 17, 2026
Isabella-Mitchell
left a comment
Isabella-Mitchell
left a comment
Contributor
There was a problem hiding this comment.
I haven't got a machine handy to test this on, but it makes sense
elvinasv
approved these changes
Jul 17, 2026
Louis-Matsika
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-3034
Summary
This pull request updates the styling for the spinner component to improve accessibility for users with forced color modes. The main change is to ensure the spinner fills with the appropriate color in these scenarios.
Code changes
spinnerstyle inMyNewsPage/styles.tsto accept amqparameter and set thefillproperty tocanvasTextwhen forced colors are enabled, enhancing visibility and accessibility. (ws-nextjs-app/pages/[service]/my-news/MyNewsPage/styles.tsL40-R46)Testing
Visit /hindi/my-news in windows machine.
Enable High contrast mode (Settings->Accessibilty->Contrast themes)
Check the loading state of mynews page
Confirm the loader is visible in all modes and normal mode as well
NightSky mode:
To see other modes evidence , check this comment:
https://bbc.atlassian.net/browse/WS-3034?focusedCommentId=364591