Skip to content

Ws 2975 fix sign in banner dialog announcation#14225

Merged
SantaZena merged 5 commits into
latestfrom
WS-2975-fix-sign-in-banner-dialog-announcation
Jul 20, 2026
Merged

Ws 2975 fix sign in banner dialog announcation#14225
SantaZena merged 5 commits into
latestfrom
WS-2975-fix-sign-in-banner-dialog-announcation

Conversation

@SantaZena

Copy link
Copy Markdown
Contributor

Resolves JIRA: https://bbc.atlassian.net/browse/WS-2975

Summary

The "Sign in" button inside the Save Article sign-in modal was not descriptive enough for screen reader users — it just said "Sign in" with no context. This change makes screen readers announce "Sign in to My News" (or the service-localised equivalent) instead, while the button still visually displays "Sign in" for sighted users.

Code changes

  • Added optional signInAccessibleLabel to the account translations type in translations.
  • Added signInAccessibleLabel: Sign in to My News" to the ws and hindi service configU
  • Updated AccountActionButtons to accept an optional signInAccessibleLabel prop
  • Updated AccountSignInModal to read signInAccessibleLabel from translations and pass it to AccountActionButtons
  • Created new test file for AccountActionButtons covering the accessible label behavior
  • Created new test file for AccountSignInModal covering the accessible label behaviour

Testing

  1. Open an article page on the hindi or ws service while signed out and with the personalisation toggle enabled
  2. Click the Save button to open the sign-in modal
  3. Using a screen reader (e.g. VoiceOver on macOS), navigate to the "Sign in" link inside the modal — it should announce "Sign in to My News" (hindi: "माय न्यूज़ में साइन इन करें"), not just "Sign in"
  4. Visually confirm the button still displays "Sign in" as before
  5. Check the same button in the AccountPromotionalBanner and My News guest page — it should still announce just "Sign in" with no change

Useful Links

https://www.dropbox.com/scl/fi/gc4na1b1ztcpql9iyyiq1/A11Y-Swarm-WS-Sign-in-pop-up-banner-trigger-Save-for-later.paper?rlkey=0uyxoi0fad6pq4zbsbtnmucvf&dl=0

@SantaZena SantaZena self-assigned this Jul 16, 2026

@elvinasv elvinasv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well from the a11y point of view 👍
As talked offline, span wrapper invalidated flex positioning, but it's an easy fix
image

Comment thread src/app/components/Account/AccountActionButtons/index.test.tsx Outdated
Comment thread src/app/components/Account/AccountSignInModal/index.test.tsx Outdated
@SantaZena
SantaZena requested review from LukasFrm and jinidev July 16, 2026 11:56
@SantaZena
SantaZena requested a review from elvinasv July 16, 2026 12:36

@elvinasv elvinasv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 👍

@LukasFrm LukasFrm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SantaZena
SantaZena merged commit e5a15c3 into latest Jul 20, 2026
17 checks passed
@SantaZena
SantaZena deleted the WS-2975-fix-sign-in-banner-dialog-announcation branch July 20, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants