WS-1882 - Remove hover/focus colour on TopicTags #13553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyL0u
approved these changes
Dec 16, 2025
elvinasv
approved these changes
Dec 16, 2025
DmitryGron
pushed a commit
that referenced
this pull request
Dec 18, 2025
elvinasv
added a commit
that referenced
this pull request
Jan 9, 2026
* WS-1838 adding tracking flag * WS-1838 adding tracking flag * updating due to comments * small update for offline hooks * updating hooks offline tracking * update offline flag to work properly * removing nextjs static assets to avoid loop reloadand some other fixes * WS-1826-collapsible-nav-for-seo * Updating unit tests * Updating unit tests nr2 * Updating unit tests nr3 * Removing right line in top nav * Fix onload condition for promo images & add blurred bg * Add isPortraitImage condition back * Move css into separate component, apply changes to MAPs * Add changes to hierarchical grid & billboard, update selectors * Make blurred background image src smaller * Fix invalid ichef image size * Prevent any fetching on lite site pages * Add stories, add isLite condition to LatestMediaSection * Add aria-hidden to BlurredBackground * Remove onLoad fix * Linting * Add fallback if ichef url fails * Update curations test * Update integration test snapshots * Revert mundo fixture * Remove isLite prop drilling, add RequestContext to BlurredBackround component * Linting * Fix stories * Fix src url * Fix LatestMediaSection styles * Add dark filter over background to make image stand out more * WS-1882 - Remove hover/focus colour on TopicTags (#13553) * WS-NA: Removes trailing comma if final contibutor has no role or location * added route for homepages as well as condition for page type header * added unit tests * updated structure of data fetch * called Homepage component to render it * renamed folder to homepage and homepage return in derived page type * removed toggles * added variant support to derivePageType utility [copilot] * added unit tests for homepage derived type * removed unneccessary keys * moved shouldRender function into utilites folder and updated imports * removed redundant props * updated shouldRender imports * fixed imports again * updated imports again * removed unused props * reinstated required props * updated cache control * updated unit tests * removed amp as it is not supported in home pages * Add test * updated readme * WS-1175: Removes optimizely dependency from article readtime * WS-1175: Refactor ReadTime component * WS-1175: Fix react issue * WS-1175: Move translations check higher up the tree * WS-1175: Reverts passing translations as prop * WS-1175: Tidy up code labelled with experiment comments * WS-1175: Fix stories and styles * WS-1175: Tidies * cache was missing * adding tests * Update index.tsx * Fix onload condition for promo images & add blurred bg * Move css into separate component, apply changes to MAPs * added route for homepages as well as condition for page type header * renamed folder to homepage and homepage return in derived page type * removing unrelated * removing unrelated * removing unrelated * removing unrelated * removing unrelated * updating audit * removing ref * simplefying offline tracking logic * upgraded the cachename in sw to see updated offlinepage * putting logs and removed isONline check from useOfflinePageFlag hook * sw changes for nextjs bundling/cache resorucing * updating test * revert sw.js to original * update testds * Update src/app/hooks/usePWAOfflineTracking/index.test.tsx Co-authored-by: Andrew Bennett <andrew.bennett07@bbc.co.uk> * updates due to comments * updates due to comments * updates due to comments * updates due to comments * Adding console logs to help debug event tracking issues * prefetching offline page in client side for js chunks pre-caching * revert prefetch , remove filtering in cache of resources * revert sw changes, removed logs * EffectiveNetworkType import issue fix * fix: undefined variable --------- Co-authored-by: Elvinas Valenas <elvinas.valenas.ext@bbc.co.uk> Co-authored-by: jinidev <jinimol.joseph.ext@bbc.co.uk> Co-authored-by: Santa Zena <santa.zena.ext@bbc.co.uk> Co-authored-by: hotinglok <hotinglok@gmail.com> Co-authored-by: Aaron Moore <aaron.moore@bbc.co.uk> Co-authored-by: Isabella-Mitchell <i.mitchell.0707@gmail.com> Co-authored-by: Nabeel Khan <nabeel.khan@bbc.co.uk> Co-authored-by: Andrew Bennett <andrew.bennett07@bbc.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arise from JIRA: https://bbc.atlassian.net/browse/WS-1882
Summary
Removes the hover/focus colouring on TopicTags, instead just using an underline
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links