Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor demo navbar #121

Merged
merged 4 commits into from
Mar 20, 2019
Merged

refactor demo navbar #121

merged 4 commits into from
Mar 20, 2019

Conversation

pietrop
Copy link
Contributor

@pietrop pietrop commented Mar 19, 2019

Is your Pull Request request related to another issue in this repository ?

Temporary fix before more substantial refactor #109

Describe what the PR does

@jamesdools as discussed, here's a refactor of the demo page navbar.

State whether the PR is ready for review or whether it needs extra work

Ready for review

Additional context
Desktop and mobile

Screen Shot 2019-03-19 at 11 20 53

Screen Shot 2019-03-19 at 11 21 13

@pietrop pietrop requested a review from jamesdools March 19, 2019 11:27
Pietro Passarelli - News Labs added 2 commits March 19, 2019 11:29
@jamesdools
Copy link
Contributor

At this point - do we even need Text Is Editable?

jamesdools
jamesdools suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@jamesdools jamesdools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement! Just a little cleanup needed. Also do we actually need to commit the package-lock considering nothing in the package.json has changed? It's noisy and adds 20k+ lines.

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@pietrop
Copy link
Contributor Author

pietrop commented Mar 19, 2019 •
edited
Loading

Yeah, I think package-lock.json was removed in previous commits. But since npm 5 it's good practice to include it as npm will handles any possible conflict itself.

see npm-package-lock.json docs

This file is intended to be committed into source repositories, and serves various purposes

@pietrop pietrop requested a review from jamesdools March 19, 2019 19:57
@pietrop
Copy link
Contributor Author

pietrop commented Mar 19, 2019

ok, done the changes, ready for merge @jamesdools

@pietrop pietrop mentioned this pull request Mar 20, 2019
Closed
12 tasks
@jamesdools jamesdools merged commit c85e814 into master Mar 20, 2019
@jamesdools jamesdools deleted the navbar-demo branch March 20, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdools jamesdools jamesdools approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietrop @jamesdools