Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stt adapter aws transcribe - Gribbs #120

Merged
merged 23 commits into from
Mar 18, 2019
Merged

Conversation

pietrop
Copy link
Contributor

@pietrop pietrop commented Mar 18, 2019

Is your Pull Request request related to another issue in this repository ?

Issue #108 and PRs #119 #118 #116 #110 by @Gribbs

Describe what the PR does

Adds support for AWS Adapter for @bbc/react-transcript-editor

State whether the PR is ready for review or whether it needs extra work

  • all tests are passing
  • commas and full stop items are joined to previous words in draftJS data model
  • tested in localhost demo app.

Additional context

  • Does not include speaker segmentation info Might be tackled as a separate PR (cc @chrishutchinson)

Thanks @Gribbs, looks all good to go, happy to merge to master, and future tweaks and improvements can be done as separate PRs.

Out of curiosity was wondering what's your use case for this component?

@pietrop pietrop changed the title Stt adapter aws transcribe gribbs Stt adapter aws transcribe - Gribbs Mar 18, 2019
@pietrop pietrop merged commit 7e1e3bd into master Mar 18, 2019
@pietrop pietrop deleted the stt-adapter-aws-transcribe-gribbs branch March 18, 2019 19:04
@pietrop pietrop added the Speech To Text Adapters Speech To Text Adapters label Mar 18, 2019
@Gribbs
Copy link

Gribbs commented Mar 18, 2019

Thanks for this! My use case isn’t fully formed yet really. I was just searching for an easy way to cleanup an AWS Transcribe job after realising the transcript file can’t be used as-is in a fully automated flow. I’m thinking I’ll setup a flow that creates a transcribe job when a video/audio file is added to S3 using AWS Lambda. This transcript file can then be cleaned up by an admin user with this component and then the clean file will be sent to another bucket on save for viewing by end users alongside the original video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Speech To Text Adapters Speech To Text Adapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants