Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout changes accessibility review #115

Merged
merged 40 commits into from
Mar 18, 2019

Conversation

jamesdools
Copy link
Contributor

@jamesdools jamesdools commented Mar 15, 2019

Describe what the PR does
Just continuing on from #111 and cleaning things up, with a few fixes.

State whether the PR is ready for review or whether it needs extra work
Currently a work in progress

Pietro Passarelli - News Labs and others added 30 commits January 3, 2019 19:43
to accomodate for two new fields
leaving rest for another branch/PR tbc
This reverts commit 2c6a9dd.
removed volume component and added titles tags to player controls btns
eg linting, css etc.. from James' PR feedback
+ Range bar re-styled
@jamesdools
Copy link
Contributor Author

Hey @ivanji, thanks so much for this! Digging the css grid work. Was just reviewing this and adding a few things, can keep you in the loop on this branch.

@jamesdools
Copy link
Contributor Author

jamesdools commented Mar 18, 2019

Appreciate the ProgressBar styling revamp - but we've been meaning to actually have it more akin to the UX mockups produced previously (attached below).

Screen Shot 2019-03-18 at 14 27 51

We're trying to keep some visual consistency with other BBC apps out there so will go with this style for now - I've updated the CSS accordingly.

@jamesdools jamesdools merged commit ad9526f into master Mar 18, 2019
@jamesdools jamesdools deleted the layout-changes-accessibility-review branch March 18, 2019 16:01
This was referenced Mar 18, 2019
@ivanji
Copy link

ivanji commented Mar 19, 2019

Appreciate the ProgressBar styling revamp - but we've been meaning to actually have it more akin to the UX mockups produced previously (attached below).

Screen Shot 2019-03-18 at 14 27 51

We're trying to keep some visual consistency with other BBC apps out there so will go with this style for now - I've updated the CSS accordingly.

This looks nice! wish I had seen this mock-up before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants