Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #154

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix CI #154

merged 1 commit into from
Mar 1, 2024

Conversation

j616
Copy link
Contributor

@j616 j616 commented Mar 1, 2024

Details

Reduce size of video grains generated by hypothesis in tests. This addresses an issue where hypothesis now restricts the size of test data which it generates. Large sizes never actually worked correctly.

Pivotal Story

Story URL:

Related PRs

Where appropriate. Indicate order to be merged.

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@j616 j616 requested a review from a team as a code owner March 1, 2024 10:30
@j616 j616 marked this pull request as draft March 1, 2024 10:39
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes suggested inline. Otherwise LGTM

@philipnbbc
Copy link
Contributor

Oh, it was changed to draft as I reviewed it :-)

@j616 j616 marked this pull request as ready for review March 1, 2024 11:05
@j616
Copy link
Contributor Author

j616 commented Mar 1, 2024

Fixes made anyway :)

@j616 j616 merged commit 060e1f1 into main Mar 1, 2024
6 checks passed
@j616 j616 deleted the jamessa-tests branch March 1, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants