Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Github Actions #140

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Move to Github Actions #140

merged 1 commit into from
Nov 1, 2023

Conversation

j616
Copy link
Contributor

@j616 j616 commented Oct 31, 2023

Details

Move to GitHub Actions for CI and releases

NOTE: This PR disables Jenkins on this repo to avoid clashes on PyPi
NOTE: A release will be required after merging as part of testing of this PR.
NOTE: Remove temporary pin before merging
NOTE: We should add links to the docs on pages in a follow-up PR once this has merged

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/186331858 and https://www.pivotaltracker.com/n/projects/2147543/stories/186190124

Related PRs

Merge after:

Links to external test runs/working deployment

Where appropriate, if separate to default CI run

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Repo maintainer is notified that a release is required
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@j616 j616 force-pushed the jamessa-gha branch 6 times, most recently from f44a439 to 746350b Compare October 31, 2023 14:43
@j616 j616 marked this pull request as ready for review October 31, 2023 14:51
@j616 j616 requested a review from a team October 31, 2023 14:52
@GeorginaShippey GeorginaShippey self-assigned this Oct 31, 2023
@j616 j616 force-pushed the jamessa-gha branch 2 times, most recently from 7596e63 to 9c7b5a0 Compare October 31, 2023 16:08
@j616 j616 marked this pull request as draft October 31, 2023 16:27
@j616 j616 marked this pull request as ready for review November 1, 2023 11:14
@j616 j616 force-pushed the jamessa-gha branch 2 times, most recently from e8578fa to 174ed35 Compare November 1, 2023 11:55
Copy link
Contributor

@GeorginaShippey GeorginaShippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@j616 j616 force-pushed the jamessa-gha branch 4 times, most recently from 78b9153 to f31c010 Compare November 1, 2023 12:16
@j616 j616 force-pushed the jamessa-gha branch 2 times, most recently from 60a45c4 to 99b6e8a Compare November 1, 2023 13:31
@j616 j616 merged commit d2de33a into main Nov 1, 2023
@j616 j616 deleted the jamessa-gha branch November 1, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants