update to allow python3 package to override py2 and vice-versa #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,2 +0,0 @@ | |||
| nmosreverseproxy* usr/lib/python2.7/dist-packages | |||
There was a problem hiding this comment.
Is this file not still required, or are the relevant files moved into place by the Python packaging?
There was a problem hiding this comment.
That file is the entire python package I think, which is handled by py2dsc.
| @@ -4,9 +4,9 @@ Wants=network-online.target | |||
| After=network.target network-online.target | |||
|
|
|||
| [Service] | |||
| ExecStart=/usr/bin/proxylisting | |||
There was a problem hiding this comment.
I get an issue when starting the py2 service which may be related to this:
Failed to start ips-reverseproxy-common.service: Unit ips-reverseproxy-common.service is not loaded properly: Invalid argument.
See system logs and 'systemctl status ips-reverseproxy-common.service' for details.
ips-reverseproxy-common.service couldn't start.
$ systemctl status ips-reverseproxy-common.service
● ips-reverseproxy-common.service - ips-reverseproxy-common
Loaded: error (Reason: Invalid argument)
Active: inactive (dead) since Fri 2019-08-30 09:15:56 BST; 21s ago
Main PID: 1843 (code=killed, signal=TERM)
|
That seems to do the job. Could you just add a version bump? I'd suggest at least minor rather than patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping that this will allow both packages to over-ride each other, so python2 and 3 packages that depend on the reverse proxy can be installed without a clash. Added a
python2explicit call in the service file for the python 2 package to override the shebang statement in the binary (which has been changed to python3)