Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of prelude-go to replace gocode backend with lsp-mode and gopls #1363

Merged
merged 7 commits into from
Apr 17, 2022
Merged

Update of prelude-go to replace gocode backend with lsp-mode and gopls #1363

merged 7 commits into from
Apr 17, 2022

Conversation

hut8
Copy link
Contributor

@hut8 hut8 commented Apr 10, 2022 •
edited
Loading

Addresses #1361

My goals are:

  • Remove gocode as much as possible.
  • go-projectile ends up installing it (and requires eldoc-go) which is not ideal, but other minor modes (like eldoc-go) require it. My development experience is fine without it, but it would be nice to have as long as it stops requiring gocode. I opened Dependency on gocode dougm/go-projectile#23 for this.
  • Remove go-eldoc because of hard dependency on gocode
  • Remove company-go because of hard dependency on gocode, and company-lsp provides better functionality.
  • Add lsp-mode and lsp-ui and integrate them with go-mode (as long as gopls is in $PATH, it works flawlessly).
  • Add docs

@hut8 hut8 changed the title Initial update of prelude-go for feedback Update of prelude-go to replace gocode backend with lsp-mode and gopls Apr 10, 2022
@bbatsov
Copy link
Owner

bbatsov commented Apr 11, 2022

I'm fine with the spirit of the proposed changes. I don't even know what gocode is and whether it has any advantages for LSP. :-)

bbatsov
bbatsov reviewed Apr 11, 2022
View reviewed changes
modules/prelude-go.el Outdated Show resolved Hide resolved
bbatsov
bbatsov reviewed Apr 11, 2022
View reviewed changes
modules/prelude-go.el Outdated Show resolved Hide resolved
@bbatsov
Copy link
Owner

bbatsov commented Apr 11, 2022

Btw, it'd be good if you also updated the related documentation for Go programming with Prelude (or create it if it's missing).

hut8 added 6 commits April 11, 2022 14:59
@hut8
Properly install hooks; remove preferences and yas
9bc23c2
@hut8
yas-global-mode is necessary to avoid company-capf error
e84587a 
company-call-backend-raw: Company: backend company-capf error "[yas]
‘yas-expand-snippet’ needs properly setup ‘yas-minor-mode’" with
args (post-completion XXX)
@hut8
remove accidental prelude-modules.el
007490e
@hut8
add gotools/ to .gitignore
600200f 
This directory is a GOPATH used by go-projectile to install tools.
@hut8
Add documentation
f403853
@hut8
add notes about GOPATH, modules, generics, and use oxford commas.
119aeca
@hut8
Copy link
Contributor Author

hut8 commented Apr 14, 2022

@bbatsov docs added as per your request. Feedback welcome 😄

@bbatsov
Copy link
Owner

bbatsov commented Apr 15, 2022

@hut8 Looks good to me.

@hut8 hut8 marked this pull request as ready for review April 15, 2022 22:37
@hut8
Copy link
Contributor Author

hut8 commented Apr 16, 2022

I think this should be good now; ready for final review.

@bbatsov bbatsov merged commit ea42da0 into bbatsov:master Apr 17, 2022
@bbatsov
Copy link
Owner

bbatsov commented Apr 17, 2022

Thanks!

@hut8 hut8 deleted the prelude-go-update branch April 26, 2022 08:59
@hut8 hut8 mentioned this pull request Jun 12, 2022
Closed
stefankeidel pushed a commit to stefankeidel/emacs-config that referenced this pull request Oct 4, 2022
@hut8 @stefankeidel
Update of prelude-go to replace gocode backend with lsp-mode and gopls (
5437126 
bbatsov#1363)
stefankeidel added a commit to stefankeidel/emacs-config that referenced this pull request Oct 4, 2022
@stefankeidel
Merge remote-tracking branch 'upstream/master'
aba66d1 
* upstream/master: (25 commits)
  Add magit-section to pinned packages
  Update installation.md
  Ignore eln-cache directory
  Minor typo fix
  [Docs] Mention flycheck-ocaml
  [Docs] Document the OCaml support
  Fix warning
  Add basic support for Literate Programming (bbatsov#1370)
  add last change to changelog
  Disable super-save on go-mode
  Document a workaround for fixing C-a in term-mode
  Bump the copyright years
  [bbatsov#1335] Workaround for which-key display bug (bbatsov#1349)
  Move go doc to new location (bbatsov#1366)
  GitHub actions CI (bbatsov#1362)
  Update of prelude-go to replace gocode backend with lsp-mode and gopls (bbatsov#1363)
  Fix contribute.md minor issues
  [DOCS] change pages to nav
  [DOCS] Add module for Rust language
  [DOCS] Add missing modules
  ...
biern pushed a commit to biern/prelude that referenced this pull request Oct 16, 2022
@hut8 @biern
Update of prelude-go to replace gocode backend with lsp-mode and gopls (
be08deb 
bbatsov#1363)
suutari-ai added a commit to suutari-ai/prelude that referenced this pull request Jan 10, 2023
@suutari-ai
Merge branch 'master' of github.com:bbatsov/prelude
995dec4 
* 'master' of github.com:bbatsov/prelude:
  Remove helm-config.
  Update rust module (bbatsov#1388)
  Search sample/prelude-modules.el in prelude-dir during init
  Documentation for prelude orgmode
  Enable cleaner org-habits
  [Docs] Update the cheatsheet output (png and pdf).
  Fix copypasta in ruby.md
  Add magit-section to pinned packages
  Update installation.md
  Ignore eln-cache directory
  Minor typo fix
  [Docs] Mention flycheck-ocaml
  [Docs] Document the OCaml support
  Fix warning
  Add basic support for Literate Programming (bbatsov#1370)
  add last change to changelog
  Disable super-save on go-mode
  Document a workaround for fixing C-a in term-mode
  Bump the copyright years
  [bbatsov#1335] Workaround for which-key display bug (bbatsov#1349)
  Move go doc to new location (bbatsov#1366)
  GitHub actions CI (bbatsov#1362)
  Update of prelude-go to replace gocode backend with lsp-mode and gopls (bbatsov#1363)
  Fix contribute.md minor issues
  [DOCS] change pages to nav
  [DOCS] Add module for Rust language
  [DOCS] Add missing modules
  [DOCS] Formating text to 80 char lines and update available modules
  [DOCS] Update the Changelog
  [DOCS] Fix problem with Edit in github link
  [DOCS] Keep index.md to 80 char lines and a couple of minor edits
  Fix "Symbol's value as variable is void: kill-region" errors in Emacs 29.0.50 (bbatsov#1356)
mklvr pushed a commit to mklvr/prelude that referenced this pull request Apr 11, 2023
@hut8
Update of prelude-go to replace gocode backend with lsp-mode and gopls (
2a663aa 
bbatsov#1363)
jmuhlich pushed a commit to jmuhlich/prelude that referenced this pull request May 23, 2023
@hut8 @jmuhlich
Update of prelude-go to replace gocode backend with lsp-mode and gopls (
e98e354 
bbatsov#1363)
Bklyn pushed a commit to Bklyn/prelude that referenced this pull request Dec 30, 2023
@hut8 @Bklyn
Update of prelude-go to replace gocode backend with lsp-mode and gopls (
87f6aed 
bbatsov#1363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbatsov bbatsov bbatsov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hut8 @bbatsov