adds cluster without site relation config #301#333
Merged
Conversation
Owner
|
Hey, Thabk you for this PR. As I'm currently traveling I'm un unable to have a look at it and test it. Could you change the destination branch to Thank you. |
Contributor
Author
|
Hi, the branch is changed. I'm also away this week, so no need to rush. 😃 |
Owner
|
Sorry it took so long. It is merged now to development branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed together in #301
This adds the possibility to add a NetBox cluster without site-relation. This is necessary if a vCenter cluster consists of hosts located in multiple NetBox sites.
cluster_site_relation: Cluster_MultiSite = <NONE>As well as installing the keyword check, I unfortunately had to change the code so that no new None site is created.
I have also described how to configure the whole thing in the configuration file and updated the example file provided.
I hope I haven't missed anything.
closes #301