Rework naming with Async suffix #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazyleu
requested changes
Sep 15, 2025
Owner
bazyleu
left a comment
bazyleu
left a comment
There was a problem hiding this comment.
Lots of compile errors in tests. Errors must be fixed before merge.
Contributor
Author
|
@bazyleu please give it another try |
bazyleu
approved these changes
Sep 16, 2025
Owner
bazyleu
left a comment
bazyleu
left a comment
There was a problem hiding this comment.
Now looks good! Thanks!
I will merge to master probably on the nearest weekend.
Owner
|
Upd: This is existing API change, so we decided this PR will be part of 2.0.0 version. Need time to prepare other changes for 2.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proper .NET async naming conventions by adding "Async" suffix to all asynchronous methods.
I would suggest bumping major version to address a lot of breaking changes. (current readme updated for migration as 1.8.0 for next version)
Breaking Changes
Migration
See "Upgrading from Versions < 1.8.0" section in README.md for detailed migration steps.
Files Updated
Fixes #101