Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve starlark-in-java installation documentation #24

Open
josharian opened this issue Dec 13, 2018 · 4 comments
Open

improve starlark-in-java installation documentation #24

josharian opened this issue Dec 13, 2018 · 4 comments
Assignees
@laurentlb

Comments

@josharian
Copy link

Both the Go and the Rust implementation of starlark have installation instructions. The Java implementation does not. It'd be nice to fill out the Java installation docs. It's not obvious to me where those docs belong (here? in a readme in https://github.com/bazelbuild/bazel/tree/master/src/main/java/com/google/devtools/skylark? in a separate/new repo just for java starlark?), but it'd be nice to have them somewhere.
@laurentlb
Copy link
Contributor

Java implementation is not easy to reuse due to dependencies on Bazel.
Tracking bug: bazelbuild/bazel#2367

As part of the cleanup, the interface might change. Once we have a clear separation, we'll provide documentation for it.

@laurentlb
Copy link
Contributor

laurentlb commented Jan 8, 2019 •
edited
Loading

Instructions if you want to experiment with it:

$ git clone https://github.com/bazelbuild/bazel.git
$ cd bazel
$ bazel build src/main/java/com/google/devtools/starlark:Starlark
$ bazel-bin/src/main/java/com/google/devtools/starlark/Starlark

Edit. updated the last commands (thanks to Josh)

@laurentlb laurentlb self-assigned this Jan 18, 2019
@laurentlb laurentlb mentioned this issue Mar 4, 2019
Closed
@Quarz0 Quarz0 mentioned this issue Mar 9, 2019
Closed
bazel-io pushed a commit to bazelbuild/bazel that referenced this issue Mar 18, 2019
@Quarz0 @copybara-github
add -c flag for Starlark-in-java
9303df6 
**Related issues:**
- add -c flag [#35](bazelbuild/starlark#35)
- improve starlark-in-java installation documentation [#24](bazelbuild/starlark#24)

**Examples:**
$ bazel run :Starlark -- -c "print(1)"
1
$ bazel run :Starlark -- -c "print(1)" arg3
USAGE: Starlark [-c "\<cmdLineProgram\>" | \<fileName\>]

Closes #7683.

PiperOrigin-RevId: 239028987
@alandonovan
Copy link
Contributor

The Java implementation now has no dependencies on Bazel proper, and now uses the java.starlark.net domain for package names, though it still lives in the Bazel repository and will do continue to do so at least until the interface has been truly stable for months.

$ git clone https://github.com/bazelbuild/bazel.git
$ cd bazel
$ bazel run src/main/java/net/starlark/java/cmd/starlark

luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
add -c flag for Starlark-in-java
42997dc 
    **Related issues:**
    - add -c flag [#35](bazelbuild/starlark#35)
    - improve starlark-in-java installation documentation [#24](bazelbuild/starlark#24)

    **Examples:**
    $ bazel run :Starlark -- -c "print(1)"
    1
    $ bazel run :Starlark -- -c "print(1)" arg3
    USAGE: Starlark [-c "\<cmdLineProgram\>" | \<fileName\>]

    Closes #7683.

    PiperOrigin-RevId: 239028987
@gl-yziquel
Copy link

Any update, in 2023, on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentlb laurentlb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@josharian @laurentlb @alandonovan @gl-yziquel