Refactor Runfile invocation and fix golint errors

devserver/BUILD.bazel

@@ -5,13 +5,16 @@ package(default_visibility = ["//visibility:public"])
 
 go_library(
     name = "go_default_library",
-    srcs = ["main.go", "runfile-filesystem.go"],
+    srcs = [
+        "main.go",
+        "runfile-filesystem.go",
+    ],
     importpath = "github.com/bazelbuild/rules_typescript/devserver",
     visibility = ["//visibility:private"],
     deps = [
         "//devserver/concatjs:go_default_library",
         "//devserver/devserver:go_default_library",
-        "//devserver/util:go_default_library",
+        "//devserver/utils:go_default_library",
     ],
 )
 

devserver/concatjs/concatjs.go

@@ -101,10 +101,10 @@ type FileSystem interface {
 	ResolvePath(root string, file string) (string, error)
 }
 
-// realFileSystem implements FileSystem by actual disk access.
-type RealFileSystem struct {}
+// RealFileSystem implements FileSystem by actual disk access.
+type RealFileSystem struct{}
 
-// Gets the last modification time of the specified file.
+// StatMtime gets the last modification time of the specified file.
 func (fs *RealFileSystem) StatMtime(filename string) (time.Time, error) {
 	s, err := os.Stat(filename)
 	if err != nil {
@@ -113,17 +113,17 @@ func (fs *RealFileSystem) StatMtime(filename string) (time.Time, error) {
 	return s.ModTime(), nil
 }
 
-// Reads the specified file using the real filesystem.
+// ReadFile reads the specified file using the real filesystem.
 func (fs *RealFileSystem) ReadFile(filename string) ([]byte, error) {
 	return ioutil.ReadFile(filename)
 }
 
-// Resolves the specified path within a given root by joining root and the filepath.
+// ResolvePath resolves the specified path within a given root by joining root and the filepath.
 // This is only works if the specified file is located within the given root in the
 // real filesystem. This does not work in Bazel where requested files aren't always
 // located within the specified root. Files would need to be resolved as runfiles.
 func (fs *RealFileSystem) ResolvePath(root string, file string) (string, error) {
-	return filepath.Join(root, file), nil;
+	return filepath.Join(root, file), nil
 }
 
 // FileCache caches a set of files in memory and provides a single

devserver/devserver/BUILD.bazel

@@ -4,7 +4,7 @@ go_library(
     name = "go_default_library",
     srcs = ["devserver.go"],
     deps = [
-        "//devserver/util:go_default_library",
+        "//devserver/utils:go_default_library",
     ],
     importpath = "github.com/bazelbuild/rules_typescript/devserver/devserver",
     visibility = ["//visibility:public"],

devserver/devserver/test/test-workspace/BUILD.bazel

@@ -2,4 +2,4 @@ filegroup(
     name = "sources",
     srcs = glob(["**/*"]),
     visibility = ["//visibility:public"],
-)
+)

devserver/utils/BUILD.bazel

@@ -14,4 +14,4 @@ go_library(
     ],
     importpath = "github.com/bazelbuild/rules_typescript/devserver/utils",
     visibility = ["//visibility:public"],
-)
+)

examples/devserver/BUILD.bazel

@@ -18,12 +18,12 @@ ts_devserver(
         "build_bazel_rules_typescript/examples/devserver/",
     ],
     static_files = [
-      # Files you want to import from the "additional_root_paths", still need to be explicitly specified
-      # as files that should be served. The root paths just make it more convenient to import those dependencies.
-      "@npm//tslib",
-      ":say-hello",
-      ":print-host",
-      ":index.html",
+        # Files you want to import from the "additional_root_paths", still need to be explicitly specified
+        # as files that should be served. The root paths just make it more convenient to import those dependencies.
+        "@npm//tslib",
+        ":say-hello",
+        ":print-host",
+        ":index.html",
     ],
     # Dependencies that produce JavaScript output will be automatically picked up by ConcatJS and will be
     # part of the serving_path bundle.
@@ -33,11 +33,11 @@ ts_devserver(
 genrule(
     name = "say-hello",
     outs = ["say-hello.js"],
-    cmd = "echo 'console.log(\"Hello!\")' > $@"
+    cmd = "echo 'console.log(\"Hello!\")' > $@",
 )
 
 genrule(
     name = "print-host",
     outs = ["test/print-host.js"],
-    cmd = "echo 'console.log(location.host)' > $@"
-)
+    cmd = "echo 'console.log(location.host)' > $@",
+)

internal/devserver/BUILD

@@ -21,7 +21,7 @@ package(default_visibility = [
 ])
 
 exports_files([
-    "ts_devserver.bzl", # Exported to be consumed for generating skydoc.
+    "ts_devserver.bzl",  # Exported to be consumed for generating skydoc.
     "launcher_template.sh",
 ])