Merged
Conversation
copybara-service
bot
requested review from
comius and
rickeylev
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_606847691
branch
3 times, most recently
from
f3eb399 to
7c1459e
Compare
Currently, If you are testing a custom provider, the API requires you to write:
env.expect.that_target(targets.foo).provider(FooInfo, factory=FooFactory)...
env.expect.that_target(targets.foo).provider(BarInfo, factory=BarFactory)...
This can get very tedious, and more importantly, is not very safe, since you can write:
env.expect.that_target(targets.foo).provider(FooInfo, factory=FooFactory)...
env.expect.that_target(targets.foo).provider(BarInfo, factory=FooFactory)...
Additionally, custom types are always rendered as "<provider>".
To solve this, we add the ability to directly specify a list of factories for custom types in your test.
analysis_test(
...,
provider_factories = [struct(type = FooInfo, name = "FooInfo", factory = FooFactory)]
)
PiperOrigin-RevId: 607174706
copybara-service
bot
force-pushed
the
test_606847691
branch
from
7c1459e to
da76c59
Compare
copybara-service
bot
closed this pull request by merging all changes
into
master
in
da76c59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for provider maps to rules_testing
Currently, If you are testing a custom provider, the API requires you to write:
env.expect.that_target(targets.foo).provider(FooInfo, factory=FooFactory)...
env.expect.that_target(targets.foo).provider(BarInfo, factory=BarFactory)...
This can get very tedious, and more importantly, is not very safe, since you can write:
env.expect.that_target(targets.foo).provider(FooInfo, factory=FooFactory)...
env.expect.that_target(targets.foo).provider(BarInfo, factory=FooFactory)...
Additionally, custom types are always rendered as "".
To solve this, we add the ability to directly specify a list of factories for custom types in your test.
analysis_test(
...,
provider_factories = [struct(type = FooInfo, name = "FooInfo", factory = FooFactory)]
)