feat: Allow setting common rule attributes for analysis tests#55
Merged
copybara-service[bot] merged 1 commit intobazelbuild:masterfrom Jul 7, 2023
Merged
Conversation
rickeylev
force-pushed
the
common.attrs
branch
4 times, most recently
from
c7db3df to
2fc8747
Compare
This allows setting common rule attributes such as tags, visibility, target_compatible_with, etc. Before this change, this was only possibly by manually invoking the underlying `testing.analysis_test()` rule to pass the `attr_values` arg. After this change, it is possible to do the equivalent by directly passing the corresponding attribute by name instead of nesting it within `attr_values`. This allows setting several useful attributes, such as tags, target_compatible_with, etc. Fixes bazelbuild#43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows setting common rule attributes such as tags, visibility, target_compatible_with, etc. Before this change, this was only possibly by manually invoking the underlying
testing.analysis_test()rule to pass theattr_valuesarg. After this change, it is possible to do the equivalent by directly passing the corresponding attribute by name instead of nesting it withinattr_values.This allows setting several useful attributes, such as tags, target_compatible_with, etc.
Fixes #43