feat: Support unit test (non-analysis test) types of tests in rules_testing#46
Merged
copybara-service[bot] merged 0 commit intomasterfrom Jun 12, 2023
Merged
feat: Support unit test (non-analysis test) types of tests in rules_testing#46copybara-service[bot] merged 0 commit intomasterfrom
copybara-service[bot] merged 0 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_539366877
branch
6 times, most recently
from
c41c65b to
d031db1
Compare
copybara-service
bot
force-pushed
the
test_539366877
branch
from
d031db1 to
6eeefb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Support unit test (non-analysis test) types of tests in rules_testing
This adds support to write tests of general Starlark code that doesn't require
analysis phase information. While this was possible to do with enough work,
it's a bit of boiler plate to do so. This moves that boiler plate into
rules_testing, so that users just need to define their verification function.
Also makes
test_suiteable to handle both basic tests (ones that are onlyan implementation function, like most unit tests) and regular tests (tests
that require a loading-phase setup process, like analyss tests).
Also creates a best practices doc. Some of the same advice pertains across
test suite, unit test, and analysis test.
Closes #37