Conversation
In doing so, make tests pass with `--experimental_sibling_repository_layout`.
comius
previously approved these changes
Jun 7, 2024
Collaborator
|
Can you run |
Contributor
Author
|
Yep, sorry. |
comius
approved these changes
Jun 7, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Apparently, `bazel coverage` will run the execution phase, even for analysis tests. This is error-prone, however, because analysis tests may not depend on fully buildable targets. To mitigate this, use `target_compatible_with` to make them as incompatible when coverage is run. Analysis tests don't implement any sort of coverage support, so nothing is lost. Along the way, add `starlark_analysis_test` tag to analysis tests. This makes it easier to match them using `--test_tag_filters` to include/exclude them in CI configs. FUTURE_COPYBARA_INTEGRATE_REVIEW=#100 from bazelbuild:lberki-update-stardoc c78f471 PiperOrigin-RevId: 676903010
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Apparently, `bazel coverage` will run the execution phase, even for analysis tests. This is error-prone, however, because analysis tests may not depend on fully buildable targets. To mitigate this, use `target_compatible_with` to make them as incompatible when coverage is run. Analysis tests don't implement any sort of coverage support, so nothing is lost. Along the way, add `starlark_analysis_test` tag to analysis tests. This makes it easier to match them using `--test_tag_filters` to include/exclude them in CI configs. FUTURE_COPYBARA_INTEGRATE_REVIEW=#100 from bazelbuild:lberki-update-stardoc c78f471 PiperOrigin-RevId: 676903010
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Apparently, `bazel coverage` will run the execution phase, even for analysis tests. This is error-prone, however, because analysis tests may not depend on fully buildable targets. To mitigate this, use `target_compatible_with` to make them as incompatible when coverage is run. Analysis tests don't implement any sort of coverage support, so nothing is lost. Along the way, add `starlark_analysis_test` tag to analysis tests. This makes it easier to match them using `--test_tag_filters` to include/exclude them in CI configs. FUTURE_COPYBARA_INTEGRATE_REVIEW=#100 from bazelbuild:lberki-update-stardoc c78f471 PiperOrigin-RevId: 676903010
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
Apparently, `bazel coverage` will run the execution phase, even for analysis tests. This is error-prone, however, because analysis tests may not depend on fully buildable targets. To mitigate this, use `target_compatible_with` to make them as incompatible when coverage is run. Analysis tests don't implement any sort of coverage support, so nothing is lost. Along the way, add `starlark_analysis_test` tag to analysis tests. This makes it easier to match them using `--test_tag_filters` to include/exclude them in CI configs. FUTURE_COPYBARA_INTEGRATE_REVIEW=#100 from bazelbuild:lberki-update-stardoc c78f471 PiperOrigin-RevId: 676903010
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Apparently, `bazel coverage` will run the execution phase, even for analysis tests. This is error-prone, however, because analysis tests may not depend on fully buildable targets. To mitigate this, use `target_compatible_with` to make them as incompatible when coverage is run. Analysis tests don't implement any sort of coverage support, so nothing is lost. Along the way, add `starlark_analysis_test` tag to analysis tests. This makes it easier to match them using `--test_tag_filters` to include/exclude them in CI configs. FUTURE_COPYBARA_INTEGRATE_REVIEW=#100 from bazelbuild:lberki-update-stardoc c78f471 PiperOrigin-RevId: 676903010
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In doing so, make tests pass with
--experimental_sibling_repository_layout.