Add always_include_developer_search_paths to mixed_language_library
#1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschear
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
keith
approved these changes
Jun 12, 2025
jschear
deleted the
js/mixed_language_always_include_developer_search_paths
branch
jschear
added a commit
to jschear/rules_swift
that referenced
this pull request
Jun 12, 2025
…y` (bazelbuild#1539) This allows Swift code in the library to depend on XCTest. If this was passed in `kwargs`, it gets passed along to the internal `objc_library` targets: ``` ~/Development/rules_swift master $ bazel build //examples/apple/mixed_language:MixedAnswer ERROR: /Users/jschear/Development/rules_swift/examples/apple/mixed_language/BUILD:5:23: //examples/apple/mixed_language:MixedAnswer_headers: no such attribute 'always_include_developer_search_paths' in 'objc_library' rule ERROR: /Users/jschear/Development/rules_swift/examples/apple/mixed_language/BUILD:5:23: //examples/apple/mixed_language:MixedAnswer_clang: no such attribute 'always_include_developer_search_paths' in 'objc_library' rule ``` We _could_ alternatively `.pop` it off of `kwargs` before passing to `objc_library`, but tracking which attributes belong to `swift_library` vs. `obj_library` and which are shared can get a bit complex.
luispadron
pushed a commit
that referenced
this pull request
Jun 12, 2025
…d_language_librar… (#1541) …y` (#1539) This allows Swift code in the library to depend on XCTest. If this was passed in `kwargs`, it gets passed along to the internal `objc_library` targets: ``` ~/Development/rules_swift master $ bazel build //examples/apple/mixed_language:MixedAnswer ERROR: /Users/jschear/Development/rules_swift/examples/apple/mixed_language/BUILD:5:23: //examples/apple/mixed_language:MixedAnswer_headers: no such attribute 'always_include_developer_search_paths' in 'objc_library' rule ERROR: /Users/jschear/Development/rules_swift/examples/apple/mixed_language/BUILD:5:23: //examples/apple/mixed_language:MixedAnswer_clang: no such attribute 'always_include_developer_search_paths' in 'objc_library' rule ``` We _could_ alternatively `.pop` it off of `kwargs` before passing to `objc_library`, but tracking which attributes belong to `swift_library` vs. `obj_library` and which are shared can get a bit complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Swift code in the library to depend on XCTest.
If this was passed in
kwargs, it gets passed along to the internalobjc_librarytargets:We could alternatively
.popit off ofkwargsbefore passing toobjc_library, but tracking which attributes belong toswift_libraryvs.obj_libraryand which are shared can get a bit complex.