Skip to content

Upstream: Add swift_common.is_action_enabled as a public API. #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

luispadron
Copy link
Contributor

@luispadron luispadron commented May 28, 2025

This allows callers to verify whether certain actions that are compiler-version-dependent, like swift-synthesize-interface, can be called by a rule or aspect.

Cherry-picks:

luispadron referenced this pull request May 28, 2025
This allows callers to verify whether certain actions that are compiler-version-dependent, like `swift-synthesize-interface`, can be called by a rule or aspect.

PiperOrigin-RevId: 733435985
luispadron referenced this pull request May 28, 2025
PiperOrigin-RevId: 731393205
luispadron referenced this pull request May 28, 2025
PiperOrigin-RevId: 738130612
@luispadron luispadron marked this pull request as ready for review May 28, 2025 19:16
@luispadron luispadron force-pushed the luis/cp-d2d94bf-and-59000d5 branch 6 times, most recently from ecd5ff8 to 8f098b4 Compare May 28, 2025 19:59
Copy link
Contributor

@aaronsky aaronsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with open question

@luispadron luispadron force-pushed the luis/cp-d2d94bf-and-59000d5 branch 2 times, most recently from aa09155 to 408e242 Compare May 29, 2025 17:43
thomasvl and others added 3 commits May 29, 2025 13:43
PiperOrigin-RevId: 731393205
This allows callers to verify whether certain actions that are compiler-version-dependent, like `swift-synthesize-interface`, can be called by a rule or aspect.

PiperOrigin-RevId: 733435985
PiperOrigin-RevId: 738130612
@luispadron luispadron force-pushed the luis/cp-d2d94bf-and-59000d5 branch from 408e242 to bb680c9 Compare May 29, 2025 17:43
@luispadron luispadron enabled auto-merge (squash) May 29, 2025 17:44
@luispadron luispadron merged commit 26cd607 into master May 29, 2025
12 checks passed
@luispadron luispadron deleted the luis/cp-d2d94bf-and-59000d5 branch May 29, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants