Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export bzl_library targets #136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Kernald
Copy link

@Kernald Kernald commented Aug 19, 2021

As discussed in #135, this is necessary for users wrapping macros/rules defined by rules_sass in their own macros/rules if they want to document them with stardoc.

This is currently blocked on bazel-contrib/rules_nodejs#2874, but should hopefully just require a bump of rules_nodejs.

bazel-contrib/rules_nodejs#2430 is needed to access
rules_nodejs's bzl_library target, which was first included after their
3.0.0 release.
Copy link
Collaborator

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending the blocking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants