fix: load providers from //:providers.bzl

[manekinekko]

BREAKING CHANGE: @build_bazel_rules_nodejs//:declaration_provider.bzl has been deleted; load from @build_bazel_rules_nodejs//:providers.bzl instead. See bazel-contrib/rules_nodejs@cc64818

[UebelAndre]

Thanks for fixing this! I think you'll also need to update the docs/BUILD.bazel:

rules_rust/docs/BUILD.bazel

Lines 7 to 19 in e589105

	bzl_library(
	name = "docs_deps",
	srcs = [
	"@bazel_tools//tools:bzl_srcs",
	"@build_bazel_rules_nodejs//internal/providers:bzl",
	"@com_google_protobuf//:bzl_srcs",
	],
	deps = [
	"@bazel_skylib//lib:paths",
	"@rules_proto//proto:defs",
	"@rules_proto//proto:repositories",
	],
	)

[UebelAndre]

It seems the rolling release builds are unable to start? Doesn't seem like this change would impact that.
cc @hlopko @philwo

edit: Understanding they're non-fatal for a PR, but they should still run so we can maintain a sense of what's working and what's not. Also, (tiny feature request) it would be fantastic to have these run in a separate job all-together. I didn't realize they were failing and I don't think anyone else will since they're hidden behind the green checkmark.

[philwo]

macOS workers do not yet have a new enough version of Bazelisk yet to support rolling releases. Will fix that next week.

RBE Rolling Bazel seems like some issue with the container config maybe. @coeuvre any idea?

[UebelAndre]

@manekinekko Seems like providers.bzl is not publicly visible?

in bzl_library rule //:docs_deps: target '@build_bazel_rules_nodejs//:providers.bzl' is not visible from target '//:docs_deps'. Check the visibility declaration of the former target if you think the dependency is legitimate. To set the visibility of that source file target, use the exports_files() function

Maybe that's an oversight in rules_nodejs?

[manekinekko]

Weird! I am using v4.2.0. Maybe that's why it's working for me.

http_archive(
    name = "build_bazel_rules_nodejs",
    sha256 = "4e1a5633267a0ca1d550cced2919dd4148575c0bafd47608b88aea79c41b5ca3",
    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/4.2.0/rules_nodejs-4.2.0.tar.gz"],
)

cc @alexeagle @gregmagolan

[alexeagle]

Hi @manekinekko nice to see you again :)

ERROR: /workdir/docs/BUILD.bazel:7:12: in bzl_library rule //:docs_deps: target '@build_bazel_rules_nodejs//:providers.bzl' is not visible from target '//:docs_deps'. Check the visibility declaration of the former target if you think the dependency is legitimate. To set the visibility of that source file target, use the exports_files() function

this is because you're referencing the providers.bzl file directly, instead you should use some filegroup target in that package that exposes all the files (probably named "bzl")

[manekinekko]

Thank you for the hint @alexeagle ❤️

@UebelAndre looks the bzl_library rule needs to be updated as well. Do you need to fix that?

rules_rust/docs/BUILD.bazel

Lines 7 to 12 in e589105

	bzl_library(
	name = "docs_deps",
	srcs = [
	"@bazel_tools//tools:bzl_srcs",
	"@build_bazel_rules_nodejs//internal/providers:bzl",
	"@com_google_protobuf//:bzl_srcs",

[UebelAndre]

Thank you for the hint @alexeagle ❤️

@UebelAndre looks the bzl_library rule needs to be updated as well. Do you need to fix that?

rules_rust/docs/BUILD.bazel

Lines 7 to 12 in e589105

	bzl_library(
	name = "docs_deps",
	srcs = [
	"@bazel_tools//tools:bzl_srcs",
	"@build_bazel_rules_nodejs//internal/providers:bzl",
	"@com_google_protobuf//:bzl_srcs",

I would expect the bzl_library to be updated if the .bzl files being used changes. I'd expect there to be some filegroup like what Alex mentioned but am not confident in my ability to read rules_nodejs since the releases are different from what I see in the actual repo.

[coeuvre]

RBE Rolling Bazel issue is fixed by #958.

[UebelAndre]

Closing this in favor of #984

Thanks for putting this together!