Update //proto rules to provide all required dependencies.
#868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've opened the following PRs to pair with the patches used to generate docs: |
|
This PR requires the following PRs: |
illicitonion
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all dependencies are currently provided by the
@rules_rust//protomodules. This PR updates the proto rules to provide these missing dependencies via a newrules_proto_transitive_repositoriesmacros.The setup instructions have been updated accordingly in the generated docs.
This change may contain a breaking change for some users who've only loaded
rules_proto_repositoriesand not called@com_google_protobuf//:protobuf_deps.bzl%protobuf_depsin their workspace. The fix for this is to simply callrules_proto_transitive_repositoriesas documented in the updated docs.