Added crate_universe examples to CI #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks great, surprisingly nice and clean! Thanks for putting so much effort into it, it definitely paid off!
Can you also remove the now-stale bootstrap bazelrc files from the .gitignores? When testing this out locally they tripped me up, and if they'd shown up in my git status it would've saved me some head-scratching :)
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
|
@illicitonion ready for another pass 😄 |
illicitonion
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new
crate_universe_bootstrapmacro which defines a repository rule for bootstrappingcrate_universe_resolverbinaries.crate_universecan now be made to bootstrap a binary (instead of downloading one) by using theRULES_RUST_CRATE_UNIVERSE_BOOTSTRAPenvironment variable and adding thecrate_universe_bootstrapmacro to yourWORKSPACEfile.The goal of this PR is to enable testing for
crate_universewhich was originally solved by the./bootstrap.shscript but this unfortunately lead to many issues. Using a repository rule to compose all the work needed for bootstrapping basically solved for all of these.