run build scripts in the crate folder instead of the workspace #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm guessing the example script was written with the assumption that it would be running from the parent folder. Presumably there is other code out there that makes such an assumption as well, so this would be a breaking change. There are lots of crates out there, and it would be unfortunate if any crates expecting crate root need to be vendored and modified to work in bazel. If changing the default is out of the question, perhaps an extra argument could be added to cargo_build_script() instead? Cargo raze could then set it automatically. |
|
#391 may be related |
|
After some though, I am fine with doing this directly. Can you fix the related tests? |
Various crates expect to be able to access files relative to the crate root, and we were giving them the parent directory (eg __main__) instead. An example crate that fails to compile without this change is blake3.
dae
force-pushed
the
build-script-default-dir
branch
from
1b27ed8
to
04c0d9d
Compare
|
Sure, test fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various crates expect to be able to access files relative to the
crate root, and we were giving them the parent directory (eg main)
instead. An example crate that fails to compile without this change
is blake3.