Skip to content

feat(rust_common): allow compile actions to declare more outdirs #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −0
Open

feat(rust_common): allow compile actions to declare more outdirs #3737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2e0249
feat(rust_common): allow compile actions to declare that extra folder…
alexeagle Nov 23, 2025
730f91a
Merge branch 'main' into extra_rust_outdirs
alexeagle Nov 26, 2025
795dc62
fix merge
alexeagle Nov 26, 2025
f8ffde9
sort
alexeagle Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rust/private/rust.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,11 @@ _common_attrs = {
"edition": attr.string(
doc = "The rust edition to use for this crate. Defaults to the edition specified in the rust_toolchain.",
),
"extra_outdirs": attr.string_list(
doc = dedent("""\
List of additional output directories which are expected to be written by the compiler.
"""),
),
"lint_config": attr.label(
doc = "Set of lints to apply when building this crate.",
providers = [LintsInfo],
Expand Down
3 changes: 3 additions & 0 deletions rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,9 @@ def rustc_compile_action(
interface_library = ctx.actions.declare_file(crate_info.output.basename + ".lib", sibling = crate_info.output)
outputs.append(interface_library)

if hasattr(ctx.attr, "extra_outdirs"):
outputs.extend([ctx.actions.declare_directory(outdir) for outdir in ctx.attr.extra_outdirs])

# The action might generate extra output that we don't want to include in the `DefaultInfo` files.
action_outputs = list(outputs)
if rustc_output:
Expand Down