Skip to content

Fixed missing cargo_toml_variable_extractor deps #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Mar 13, 2025

This fixes issues specifically for missing a rules_rust_ctve repository but others I wouldn't have expected to be missing unless users forgot to add the following to their WORKSPACE.bazel files

load("@rules_rust//cargo:deps.bzl", "cargo_dependencies")

cargo_dependencies()

Users just using crate_universe and not cargo_toml_env_vars directly should be fine using the standard crate_universe setup macros

load("@rules_rust//crate_universe:repositories.bzl", "crate_universe_dependencies")

crate_universe_dependencies()

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

@UebelAndre UebelAndre added this pull request to the merge queue Mar 14, 2025
Merged via the queue into bazelbuild:main with commit ed85e89 Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants