Skip to content

Added safari support for rust_wasm_bindgen_test #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Mar 11, 2025

Additionally fix missing wasm-bindgen CI tests

@UebelAndre UebelAndre force-pushed the wasm-bindgen branch 2 times, most recently from 629d750 to 08c3417 Compare March 11, 2025 21:57
@UebelAndre UebelAndre marked this pull request as ready for review March 12, 2025 00:57
@UebelAndre UebelAndre requested a review from illicitonion March 12, 2025 00:57
@UebelAndre UebelAndre enabled auto-merge March 12, 2025 00:57
@UebelAndre UebelAndre mentioned this pull request Mar 13, 2025
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting to be quite a lot of webdriver infra which feels like maybe it should live in another ruleset?

@UebelAndre UebelAndre added this pull request to the merge queue Mar 14, 2025
@UebelAndre
Copy link
Collaborator Author

This is getting to be quite a lot of webdriver infra which feels like maybe it should live in another ruleset?

I would love for there to be a maintained module for each webdriver thing! That may be a larger conversation that I'll kick off somewhere.

Merged via the queue into bazelbuild:main with commit a002c94 Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants